Repository navigation
fix: don't hang indent the second operand of a multi-line comparison - #884
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #747
A multi-line comparison got a hanging indent on its second operand in places where other binary expressions like
+and&&stay at the first operand's level (indentWidth: 4,binaryExpression.operatorPosition: sameLine):Comparison operators (
==,!=,===,!==,<,<=,>,>=) are now treated like the other operators that don't indent there (ex. return andifparens, arrow function bodies, and array elements):Call arguments, expression statements, assignments and comparisons nested in another binary expression still indent the same way
+does.This changes default output. In the regression corpus I use, it changed 127 files (mostly broken
if (conditions) and the output is stable.Tests
issue0747.txthas the issue's example, plus comparisons in return parens, arrow function bodies, array elements and call arguments.BinaryExpression_All.txthas a "should format comparisons inline" case with all eight operators, like the existing bitwise, bitshift and mod cases.IfStatement_SpaceAround_True.txtno longer indents its<=line.